search

mapnik / Cascadenik

Cascading Sheets Of Style for Mapnik
http://github.com/mapnik/Cascadenik/wiki/Cascadenik
BSD 3-Clause "New" or "Revised" License
111 stars 20 forks source link

Remove text-force-odd-labels #39

Closed mojodna closed 10 years ago

mojodna commented 10 years ago

mapnik/mapnik#2120 removed force_odd_labels, which may have never worked (according to comments in that issue). When used with recent mapnik-2.3 nightlies, Cascadenik fails with the following error:

Traceback (most recent call last):
  File "/usr/local/bin/cascadenik-compile.py", line 100, in <module>
    sys.exit(main(layersfile, outputfile, **options.__dict__))
  File "/usr/local/bin/cascadenik-compile.py", line 33, in main
    cascadenik.load_map(mmap, src_file, dirname(realpath(dest_file)), **load_kwargs)
  File "/usr/local/lib/python2.7/dist-packages/cascadenik/__init__.py", line 90, in load_map
    compile(src_file, dirs, verbose, datasources_cfg=datasources_cfg, user_styles=user_styles, scale=scale).to_mapnik(map, dirs)
  File "/usr/local/lib/python2.7/dist-packages/cascadenik/output.py", line 74, in to_mapnik
    sym = symbolizer.to_mapnik(fontsets)
  File "/usr/local/lib/python2.7/dist-packages/cascadenik/output.py", line 396, in to_mapnik
    sym.properties.force_odd_labels = self.force_odd_labels.value if self.force_odd_labels else sym.properties.force_odd_labels
AttributeError: 'TextSymbolizerProperties' object has no attribute 'force_odd_labels'
springmeyer commented 10 years ago

added you to commit, merge away.

mojodna commented 10 years ago

Do you have push privs to pypi to publish a new version?

springmeyer commented 10 years ago

I do, this is what I see:

Package Index Owner: rcoup, migurski, springmeyer, nvkelso
Package Index Maintainer: nvkelso
springmeyer commented 10 years ago

I need to leave right now, can I add you as an owner so you can upload?

mojodna commented 10 years ago

Sure, that'd be great.

Since there are no mapnik-2.2 binaries for Ubuntu 14.04, others might run into this, so I figure it'll be nice to drop an updated release.

springmeyer commented 10 years ago

What is your pypi username?

On May 23, 2014, at 5:30 PM, Seth Fitzsimmons notifications@github.com wrote:

Sure, that'd be great.

Since there are no mapnik-2.2 binaries for Ubuntu 14.04, others might run into this, so I figure it'll be nice to drop an updated release.

— Reply to this email directly or view it on GitHub.

mojodna commented 10 years ago

mojodna