search

mapnik / clipper

Boost Software License 1.0
8 stars 5 forks source link

Debian packaging #1

Closed sebastic closed 8 years ago

sebastic commented 8 years ago

Since the mapnik Debian package was updated to 3.0.x, the mapnik-vector-tile package has become unusable. The recent mapnik-vector-tile releases require this clipper fork which is not available in Debian yet. The git repo cannot be cloned as part of the build process because Debian build environments have no network connectivity.

Now the question is how to best package mapnik/clipper for Debian to allow mapnik-vector-tile to build again.

The only requirement for the mapnik-vector-tile build seems to be the availability of the modified clipper.hpp in the include paths.

We can easily install clipper.hpp in /usr/include/mapnik along with the other mapnik headers for example. This may not require a separate package, we can also include it as a patch in the mapnik package.

Because we already have the polyclipping library packaged in Debian (as libpolyclipping) we cannot build this mapnik fork as-is because it uses the same library name instead of something like libmapnikclipper for example. This doesn't appear to be much of an issue, because only the single header is used, not the shared library.

If my assessment is correct, would it make sense to include the fixed clipper.hpp in the mapnik releases to not require this repository as part of the mapnik-vector-tile build?

springmeyer commented 8 years ago

Thanks for raising this issue. Perhaps a simpler solution would be not to package mapnik-vector-tile separately. The design of mapnik-vector-tile is to be bundled by a developer rather than used as a separate package. Then when doing debian packaging of something that bundled mapnik-vector-tile it and the clipper.hpp would already be there.

sebastic commented 8 years ago

The mapnik-vector-tile package exists because it's required for the node-mapnik package, which in turn is required for the node-tilelive-{bridge,mapnik,vector} packages.

These packages have all been removed from testing (and the next stable release through that) because of the outstanding release critical bug in mapnik-vector-tile. Based on your feedback that seems like a good thing, so we should probably remove mapnik-vector-tile and its reverse dependencies from unstable (and Ubuntu through that) too.

I'm not the maintainer of any of these packages (I've only recently started to help with the mapnik & python-mapnik packages), so I'll need to file some bugs to document the need to removal of these packages from the Debian archive.

sebastic commented 8 years ago

As discussed with @kapouer in Debian Bug #789942, we need to keep the mapnik-vector-tile & node-mapnik packages around in Debian for the time being.

Also from the bugreport:

I've created initial Debian packaging for mapnik/clipper [0], and updated mapnik-vector-tile [1] to use that package.

mapnik-vector-tile (0.10.0+dfsg-1) now builds successfully, but a test does fail.

[0] https://anonscm.debian.org/cgit/pkg-grass/mapnik-clipper.git [1] https://anonscm.debian.org/cgit/pkg-grass/mapnik-vector-tile.git

Whether or not to bundle the clipper.{c,h}pp files in mapnik-vector-tile is still to be decided. Since it's only two files I'm leaning towards bundling.

sebastic commented 8 years ago

I've opted to bundle clipper.{c,h}pp in the mapnik-vector-tile Debian package for the time being to resolve the outstanding RC bug.

Debian packaging for mapnik-clipper is also available, but unused until there are other packages that need it. This should resolve this issue.