osx/settings.sh overrides the debug flags from mapbox-gl-native

mapnik / mapnik-packaging

DEPRECATED packaging utilities for mapnik dependencies

39 stars 28 forks source link

osx/settings.sh overrides the debug flags from mapbox-gl-native #166

Closed ljbade closed 9 years ago

ljbade commented 10 years ago

When I build mapbox-gl-native like: make android BUILDTYPE=Debug (which adds -DDEBUG -O3 to the compile flags)

I do not get a proper debug binaries because the flags are overridden by osx/settings.sh as it also adds -DNDEBUG -O3 to the compile flags.

I had to edit settings.sh with: export OPTIMIZATION="0" export DEBUG_FLAGS="-DDEBUG"

Can this be fixed? I do not know how it should be done without breaking other stuff.

ljbade commented 9 years ago

Just going through old issues I still have open. It appears this was never changed? Makes it difficult if I need to build debug libraries.

springmeyer commented 9 years ago

We are planning on avoiding source compiles with mapnik-packaging in the near future so I recommend just working around this for now like you have done. Excited to have you back working on this. Do flag any other issues you see.

ljbade commented 9 years ago

While you are here, I noticed that mapnik-packing now compiles the libraries as Android-L Arm64? Is this just for testing? I don't have a phone that runs that.