Restore pull requests - Githubissues

mapnik / mapnik-reference

JSON specification of Mapnik styling and datasources

http://mapnik.org/mapnik-reference/

The Unlicense

50 stars 48 forks source link

Restore pull requests #117

Open springmeyer opened 8 years ago

springmeyer commented 8 years ago

A few outstanding pull requests were automatically closed (and cannot be re-opened) now that I've deleted the master branch and we use gh-pages as default (https://github.com/mapnik/mapnik-reference/pull/107#issuecomment-139035521). This ticket is to track those pulls for revisiting when there is time:

[x] https://github.com/mapnik/mapnik-reference/pull/114
[x] https://github.com/mapnik/mapnik-reference/pull/109
[ ] https://github.com/mapnik/mapnik-reference/pull/62 (if carto pull is ever accepted)
[ ] https://github.com/mapnik/mapnik-reference/pull/61 (if carto pull is ever accepted)

nebulon42 commented 8 years ago

I plan to work on #61 and #62 again as time permits, because I think that they are important additions. However, accepting the changes into this repository would be a prerequisite for accepting them into carto.

springmeyer commented 8 years ago

@nebulon42 - that is great you are interested in working on the group-symbolizer support. Also, with further thought I agree that it likely makes sense to land in mapnik-reference first. I'm open to this as long as we mark all the properties as experimental.

talaj commented 8 years ago

@springmeyer - given the fact that corresponding carto pull requests for #62 and #61 can never land and according to importance of mapnik-reference for non-carto users, what about to merge these pull requests with some "area of validity" introduced to exclude it from carto? Something similar to https://github.com/mapnik/mapnik-reference/issues/101.

springmeyer commented 8 years ago

👍 @talaj - Agree that anything in Mapnik should be visible in mapnik-reference irregardless of its binding in carto