search

mapnik / mapnik

Mapnik is an open source toolkit for developing mapping applications
http://mapnik.org
GNU Lesser General Public License v2.1
3.68k stars 826 forks source link

Regression parsing topojson #3929

Closed springmeyer closed 6 years ago

springmeyer commented 6 years ago

Latest mapnik, via node-mapnik@4.0.0, attempts to parse https://github.com/mapbox/mapnik-omnivore/blob/master/test/fixtures/invalid-topojson/missingfeatures.json and hits:

# [TopoJson] getLayers: no features
failed to parse TopoJSON...
boost::spirit::x3::expectation_failure
Expected: N5boost6spirit2x311alternativeINS1_6actionINS1_4ruleIN6mapnik4json7grammar23geometry_collection_tagESt6vectorIN6mapbox4util7variantIJNS5_8topojson5emptyENSD_5pointENSD_10linestringENSD_7polygonENSD_11multi_pointENSD_16multi_linestringENSD_13multi_polygonEEEESaISL_EELb0EEENS7_3$_4EEENS3_INS4_INS7_12geometry_tagESL_Lb0EEENS7_3$_5EEEEE Got: " [] }���i�qNNN5boost6spirit2x311alternativeINS1_6actionINS1_4ruleIN6mapnik4json7grammar23geometry_collection_tagESt6vectorIN6mapbox4util7variantIJNS5_8topojson5e..."
/home/travis/build/mapbox/mapnik-omnivore/node_modules/tape/index.js:75
        throw err
        ^
Error: topojson_datasource: Failed parse TopoJSON file '/home/travis/build/mapbox/mapnik-omnivore/test/fixtures/invalid-topojson/missingfeatures.json'

https://travis-ci.org/mapbox/mapnik-omnivore/jobs/399211963#L1254

springmeyer commented 6 years ago

🙏 thank you @lightmare