search

mapnik / python-mapnik

Python bindings for mapnik
GNU Lesser General Public License v2.1
160 stars 91 forks source link

GDAL plugin not use overview for GeoTiff #175

Open winsento opened 6 years ago

winsento commented 6 years ago

GDAL plugin not use overview for GeoTiff

Tested on:

On Ubuntu 14.04, python-mapnik installed from repository v3.0.9 and MacOS v3.0.13 from brew - all OK

talaj commented 6 years ago

I'm a bit suspicious https://github.com/mapnik/mapnik/pull/3668 is the culprit.

This condition in GDAL is not fulfilled: https://github.com/OSGeo/gdal/blob/b2d44355766dce069a027777f6bbd5c31bd98c56/gdal/frmts/gtiff/geotiff.cpp#L4114

Because of image.width == width here: https://github.com/mapnik/mapnik/blob/43d7278352e95b2e7a2371f2b4d56dfd95ab566a/plugins/input/gdal/gdal_featureset.cpp#L218-L222

talaj commented 6 years ago

I can confirm https://github.com/mapnik/mapnik/pull/3668 ruined overviews.

talaj commented 6 years ago

The problem has been fixed in Mapnik.