mapnik / python-mapnik

Python bindings for mapnik
GNU Lesser General Public License v2.1
160 stars 91 forks source link

Pybind11 [WIP] #276

Closed artemp closed 3 months ago

artemp commented 5 months ago

Port to pybind11 and remove dependency on boost::python.

FYI @mathisloge

mathisloge commented 5 months ago

Oh cool @artemp ! You could take a look at scikit-core. They have an example here: https://github.com/pybind/scikit_build_example

In my experience it's quite easier to develop with, since you will have a normal cmake setup or the python packaging process.

artemp commented 5 months ago

You could take a look at scikit-core. They have an example here: https://github.com/pybind/scikit_build_example

In my experience it's quite easier to develop with, since you will have a normal cmake setup or the python packaging process.

@mathisloge I will definitely take a look, thanks! As a first iteration I'd like to ensure setuptools are updated and are working. But I'm aware pybind11 integrates well with CMake, which would be the next step.

artemp commented 4 months ago

pytest test/python_tests 🟢 ==== 390 passed in 29.22s ==

Remaining TODO: Fix handling of uninitialised placement finder(s) in text rendering in mapnik core + add missing properties to symbolisers