Add mapping relations - Githubissues

mapping-commons / semantic-mapping-vocabulary

https://mapping-commons.github.io/semantic-mapping-vocabulary/

10 stars 3 forks source link

Add mapping relations #14

Closed gouttegd closed 1 year ago

gouttegd commented 1 year ago

This PR implements the proposal in #3.

That is, it adds properties intended to represent mapping relations:

skos:semanticRelation
- skos:mappingRelation
- skos:closeMatch
  - skos:exactMatch
- semapv:isomorphicMatch
  - skos:exactMatch
  - semapv:crossSpeciesExactMatch
- semapv:nonIsomorphicMatch
  - skos:broadMatch
  - semapv:crossSpeciesBroadMatch
  - skos:narrowMatch
  - semapv:crossSpeciesNarrowMatch
  - skos:relatedMatch
  - semapv:crossSpeciesExactMatch

gouttegd commented 1 year ago

Following discussion with @matentzn, semapv:crossSpeciesCloseMatch to be added (in addition to the changes already requested above) before the PR can be merged.

@matentzn : Not sure where you intended to place this relation? As a direct subclass of skos:closeMatch? Of semapv:nonIsomorphicMatch? Of both?

matentzn commented 1 year ago

Ready to merge?

gouttegd commented 1 year ago

If you’re happy with it, yes.

matentzn commented 1 year ago

THANK YOU!

gouttegd commented 1 year ago

:tada: This is only 253 days after that meeting with Shawn and David when we first talked about the need for specific relations for cross-species mappings, and in which you told me “just open a ticket on OMO to request these relations and I’ll make sure they are created.” :D

matentzn commented 1 year ago

Thats nothing :P Fast turnaround!

gouttegd commented 1 year ago

I kind of knew you were going to say that! :D

cthoyt commented 1 year ago

this is great! Thanks @gouttegd , I will switch biomappings over to use these newly minted relations too :)