search

mapping-commons / sssom-api

Apache License 2.0
7 stars 0 forks source link

Add mapping id to JSON response in `mappings` endpoint #34

Closed anitacaron closed 1 year ago

anitacaron commented 1 year ago

Add mapping_id in the others key object inside Mapping dataclass

anitacaron commented 1 year ago

The other attribute is a string (REF), so it's not straightforward to get mapping_id from this attribute. None of the other attributes could fit this request too.

matentzn commented 1 year ago

Just provide a nested Json blop, like a dictionary, in the "other" field.

anitacaron commented 1 year ago

We need to change the description in the documentation to align with json blop.

Slot: other Pipe separated list of key value pairs for properties not part of the SSSOM spec. Can be used to encode additional provenance data.

matentzn commented 1 year ago

You are right! Can you take care of it?

anitacaron commented 1 year ago

Nico proposed a new slot for this attribute in the SSSOM model.

anitacaron commented 1 year ago

After some meetings, it was decided not to change the SSSOM model. The solution is to have endpoints only for the UI; we can add any field important for the UI and one that is SSSOM conform.