search

mapping-commons / sssom-py

Python toolkit for SSSOM mapping format
https://mapping-commons.github.io/sssom-py/index.html#
MIT License
49 stars 12 forks source link

Band-aid fix for defaulting mappings() to an empty list #177

Closed hrshdhgd closed 2 years ago

hrshdhgd commented 2 years ago

This is in reference to this code in cliques.py

# ** THIS BLOCK IS A BAND-AID SOLUTION **********************************************
    #   DEPENDENT ON A LINKML BUG FIX REPORTED AT
    #   https://github.com/linkml/linkml/issues/477

    for item in documents:
        if item.mapping_set.mappings == {}:
            item.mapping_set.mappings = []
        logging.warning(
            "****** MAPPINGS IS FORCED TO BE AN EMPTY LIST.[cliques.py -> def split_into_cliques()] *****"
        )
   # **********************************************************************************

associated with commit https://github.com/mapping-commons/sssom-py/pull/172/commits/7b6c7e2641db3e550479272c7211cb1cef111183

hrshdhgd commented 2 years ago

This needs to be fixed. Opened a ticket in linkml to address this.

hrshdhgd commented 2 years ago

This PR takes care of this issue