mapping-commons / sssom-py

Python toolkit for SSSOM mapping format
https://mapping-commons.github.io/sssom-py/index.html#
MIT License
49 stars 12 forks source link

Make sure that `parse` can work without needing to pass a metadata `.yml` #228

Closed joeflack4 closed 2 years ago

joeflack4 commented 2 years ago

See: https://github.com/mapping-commons/sssom-py/issues/227#issuecomment-1101205374

The following should work w/out needing a metadata .yml: sssom parse omim.json -I obographs-json -o omim.sssom.tsv

It should warn and populate with defaults if any of the following are missing:

And should have the prefixes for HGNC, Orphanet, etc loaded.

matentzn commented 2 years ago

@joeflack4 We are working on related code so its probably best if @hrshdhgd takes care of this.

cmungall commented 2 years ago

Note that it's now possible to use OAK to export SSSOM on either a per-term or per-ontology basis

https://incatools.github.io/ontology-access-kit/cli.html#runoak-mappings

longer term we may want sssom-py to focus on processing operations and leave conversion operations to other libs?

matentzn commented 2 years ago

I think there are so many non-ontology parsing processes we are working on (alignment API, complex map), that probably some redundancy is unavoidable. Basically the only piece of overlap is the obographs json parser - I think this is ok.

cmungall commented 2 years ago

Agreed, just wanted to make sure we weren’t spending too much time on it

On Mon, May 2, 2022 at 10:44 AM Nico Matentzoglu @.***> wrote:

I think there are so many non-ontology parsing processes we are working on (alignment API, complex map), that probably some redundancy is unavoidable. Basically the only piece of overlap is the obographs json parser - I think this is ok.

— Reply to this email directly, view it on GitHub https://github.com/mapping-commons/sssom-py/issues/228#issuecomment-1115167196, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMMOKNRUFL73KAVAXG3MTVIAH7HANCNFSM5TWC3O5A . You are receiving this because you commented.Message ID: @.***>

matentzn commented 2 years ago

Hopefully fixed by #238