Some missing msdf returns

mapping-commons / sssom-py

Python toolkit for SSSOM mapping format

https://mapping-commons.github.io/sssom-py/index.html#

MIT License

49 stars 12 forks source link

Some missing msdf returns #44

Closed matentzn closed 3 years ago

matentzn commented 3 years ago

from_alignment_minidom
from_dataframe
from_obographs
from_owl_graph
from_rdf_graph

I think these are all :) Some of these are not even implemented yet, but lets be proactive! :)

hrshdhgd commented 3 years ago

Shouldn't from_dataframe return a MappingSetDocument? As of now to_mapping_set_document implements from_dataframe to convert MappingSetDataFrame => MappingSetDocument as seen here

matentzn commented 3 years ago

Yeah we were not too clear about that, I would kind of want nothing to return MappingSetDocument - in the end I want to get rid of it altogether.

matentzn commented 3 years ago

Other than the utility methods i mean, and maybe some intermediate stuff