Prefixes should be checked against .bimap instead of .prefix_map

mapping-commons / sssom-py

Python toolkit for SSSOM mapping format

https://mapping-commons.github.io/sssom-py/index.html#

MIT License

49 stars 12 forks source link

Prefixes should be checked against .bimap instead of .prefix_map #471

Closed hrshdhgd closed 9 months ago

hrshdhgd commented 9 months ago

Fixes #469

Relates to #461
Relates to https://github.com/cthoyt/curies/issues/96

cthoyt commented 9 months ago

Disagree. Prefixes should be checked if they can be standardized. Then you standardize all of them, which results in them all being part of the bimap.

cthoyt commented 9 months ago

Please don't merge this without me taking a final review

matentzn commented 9 months ago

No longer needed, check https://github.com/mapping-commons/sssom-py/pull/473