search

mapping-commons / sssom-py

Python toolkit for SSSOM mapping format
https://mapping-commons.github.io/sssom-py/index.html#
MIT License
49 stars 12 forks source link

Laziload global MAPPING_SLOTS variable #482

Closed matentzn closed 8 months ago

matentzn commented 8 months ago

Fixes #481

matentzn commented 8 months ago

I am not a programmer and I dont know the cost of "set()". If this is negligible on the scale of of 1 million operations, I would use lru cache of the schema object. What do you think?

matentzn commented 8 months ago

@cmungall I am now simply passing the mapping_slots variable into the function and declare the variable in the calling function. globals are gone.

matentzn commented 8 months ago

Thank you @cthoyt!