search

mapping-commons / sssom-py

Python toolkit for SSSOM mapping format
https://mapping-commons.github.io/sssom-py/index.html#
MIT License
48 stars 10 forks source link

UX: Second empty line break at bottom of file #515

Open joeflack4 opened 3 months ago

joeflack4 commented 3 months ago

Overview

Just a super small UX issue I noticed. When using write_table(), there's a second empty line break getting inserted at the end of my TSV. I'm not sure if this is intentional. But the standard I usually come across is 1 blank line at the end, or 0 blank lines.

matentzn commented 3 months ago

Hm. I am assuming you are using write_table().

The problem must be located in this line: https://github.com/mapping-commons/sssom-py/blob/be8a77b5a2ef42cd2b92b74d892d7626dec27471/src/sssom/writers.py#L69

Do you see something obviously wrong with it?

joeflack4 commented 3 months ago

Ah yes, write_table()! I haven't seen something obviously wrong, but I haven't looked. I can take a look, though.