search

mapping-commons / sssom-py

Python toolkit for SSSOM mapping format
https://mapping-commons.github.io/sssom-py/index.html#
MIT License
48 stars 10 forks source link

`TestWrite.test_missing_entries()` #534

Open joeflack4 opened 2 months ago

joeflack4 commented 2 months ago

Overview

Addresses part of #513. Creates a test to check for missing entries in prefix_map / curie_map after initializing MappingSetDataFrame.

matentzn commented 2 months ago

Can you give more detail here? What exactly is missing and why?

joeflack4 commented 2 months ago

Looks like I accidentally wrote "Addresses part of #533", but meant to write "Addresses part of #513". The detail is in that issue, #513.

I don't remember why I felt the need to create a sub-issue for this test.

In any case, to summarize #513, basically I noticed that, even though I had icd11.foundation in the curie_map in my metadata .yml, and in at least 1 of the rows in my mapping set, it was not showing up in the curie_map in the metadata comment when I wrote to TSV.