search

mapping-commons / sssom

Simple Standard for Sharing Ontology Mappings
https://mapping-commons.github.io/sssom/
BSD 3-Clause "New" or "Revised" License
144 stars 24 forks source link

Why is mapping_justification a required field? #211

Closed cmungall closed 2 years ago

cmungall commented 2 years ago

Given that this can be populated with semapv:UnspecifiedMatching, why not just have null value mean unspecified, which is literally one of the things null means

as it is, we have

  1. A whole bunch of files in the mapping-commons org that fail parsing because schema checking fails
  2. inflation of sizes of already potentially large uncompressed TSV files communicating zero bits of information

Perhaps we could at least have an option in the parser to auto-populate this so it's possible to work with legacy files?

matentzn commented 2 years ago

I tried this before, see #117

It was rejected by other team members.. The argument for having this required is based on the assumption that, if it is not, not even a half baked attempt will be made to explain how the mapping came into being. I am also now firmly in the camp to having it required, and if you use "sempav:UnspecifiedMapping" you are deliberately exposing your ignorance over how the mappings came into being..

cmungall commented 2 years ago

you are deliberately exposing your ignorance over how the mappings came into being

My 3 decades of observing the social dynamics of how people interact with required fields begs to differ. Remind me to tell you the Pray For Elves celera story.

Anyway, I firmly believe this was the wrong decision but if the majority is against, so be it.