Make it possible to use the promise-based API

mappum / electron-webrtc

⚛ Use WebRTC in Node.js via a hidden Electron process

317 stars 47 forks source link

Make it possible to use the promise-based API #91

Open getkey opened 7 years ago

getkey commented 7 years ago

Actually that doesn't work, sorry. I'm working on a fix.

getkey commented 7 years ago

@mappum Thought on this PR?

It would be nice to support Promises since MDN says the callback API is deprecated.

mappum commented 7 years ago

@getkey Sorry I missed this. Thanks for making this PR, keeping the API up-to-spec is important. I'll check this out/merge it later this week when I get time.

getkey commented 7 years ago

Great, thanks!

getkey commented 7 years ago

@mappum Hey, sorry to bug you again but have you had time to check it out? (and PR #92, too)

getkey commented 7 years ago

I published the NPM package electron-webrtc-patched because I need the changes in this PR. I will take it down if my PRs are accepted.