search

mappum / webcoin

:globe_with_meridians::moneybag: SPV Bitcoin client for Node.js and the browser
412 stars 60 forks source link

Make the user pass in a WebRTC implementation (for #7) #12

Closed paulkernfeld closed 8 years ago

paulkernfeld commented 8 years ago

Hopefully this change isn't too invasive. This seemed like the most straightforward way to do it.

Also a quick note that this is a breaking change.

mappum commented 8 years ago

Hey @paulkernfeld, thanks for contributing! Although I should let you know that a lot of the code inside this repo is already being moved into smaller repos, see the roadmap in the README for links.

paulkernfeld commented 8 years ago

Ah, okay, now I see that this is approach is already implemented in peerGroup in bitcoin-net for example, so that will make this PR obsolete soon. Do you have an ETA for finishing the refactor?

mappum commented 8 years ago

Do you have an ETA for finishing the refactor?

I'm looking to get it done ASAP, but I'm bad at time estimates. Maybe 3 or 4 days of work. #13

paulkernfeld commented 8 years ago

Nice! That's super fast, so it's probably not worth it to merge this PR.

mappum commented 8 years ago

Closing because this feature is in bitcoin-net.

paulkernfeld commented 8 years ago

Awesome!