Closed paulkernfeld closed 8 years ago
This is due to the wrtc
package being broken. The network code is being broken out into the bitcoin-net
repo, and wrtc
won't be a dependency (so these errors won't have to happen, and so that users can provide their own implementation such as electron-webrtc
.
What do you think of removing wrtc from the optional dependencies, and making people install or link a webrtc implementation themselves? Simple-peer follows that pattern. I believe that would remove noise and speed up builds, although at the cost of convenience for some users.
在 2016年2月2日,09:57,ᴍᴀᴛᴛ ʙᴇʟʟ notifications@github.com 写道:
This is due to the wrtc package being broken. The network code is being broken out into the bitcoin-net repo, and wrtc won't be a dependency (so these errors won't have to happen, and so that users can provide their own implementation such as electron-webrtc x-msg://2/mappum/electron-webrtc.
— Reply to this email directly or view it on GitHub https://github.com/mappum/webcoin/issues/7#issuecomment-178455053.
I agree, that's the way to go.
I'm working on a PR for making users pass in a WebRTC implementation. I'm seeing a couple test failures even without my change (#9 and #10), so I want to make sure the tests are stable before submitting the PR.
Closing, now annoying dependencies like wrtc
are passed in by the user.
This might not be super high priority: my build succeeds and I believe that my installation works when I install wrtc, but there are a lot of warnings caused by optional dependencies, which makes it hard to see if there are important problems. I'm running node 5.5 on OSX 10.10.