Challenges are often kept as active despite having no tasks

maproulette / maproulette-backend

MapRoulette back-end / API

Apache License 2.0

50 stars 37 forks source link

Challenges are often kept as active despite having no tasks #1092

Open matkoniecz opened 9 months ago

matkoniecz commented 9 months ago

see for example https://maproulette.org/browse/challenges/40603

https://maproulette.org/challenge/41154

https://maproulette.org/challenge/40667

KasperFranz commented 9 months ago

Same for https://maproulette.org/browse/challenges/40496

matkoniecz commented 9 months ago

may be caused by changing task state via API, not user interface?

Maybe I trigger it when last task is set to "disabled" not "fixed"?

matkoniecz commented 4 months ago

I got report that it is still a problem. See

https://maproulette.org/browse/challenges/40109

https://maproulette.org/browse/challenges/42290

https://maproulette.org/browse/challenges/42119

which were given as examples.

ljdelight commented 2 weeks ago

It does look like this is caused by tasks that are Disabled, and that prevents the Challenge from being completed. For challenge 40109: I don't see anything in the UI that indicates disabled tasks; the GET challenge API call response shows a completionPercentage of 100 and yet the challenge remains active; then the GET challenge data shows 12 tasks, 9 fixed, 3 disabled, 11 deleted.

I bet there's some task completion logic that needs to be updated to account for disabled tasks, or perhaps it's intentional and should be more obvious in the UI.

matkoniecz commented 2 weeks ago

Disabled tasks definitely should not keep a challenge open. If they do, what is the point of having them?

(in fact - what is the point of having both disabled and deleted?)

mvexel commented 2 weeks ago

disabled may make sense to a challenge author, to have tasks that they temporarily want to have not included but for whatever reason they do not want to delete, because they may want to re-enable them later.

From an end user perspective this status really does not have any meaning.

So what we'll do is

On the front end, do not count the disabled tasks in the totals. So in the above example, the total task count that the user sees would be 9 and not 12 (separate ticket to be created for that)
On the backend, once a challenge has only deleted or disabled tasks left, we mark it as completed.