search

maproulette / maproulette-backend

MapRoulette back-end / API
Apache License 2.0
50 stars 38 forks source link

Perf: Remove 'connectionTestQuery' from application.conf #1123

Closed ljdelight closed 5 months ago

ljdelight commented 5 months ago

Remove application.conf 'db.default.hikaricp.connectionTestQuery' to allow the driver to use the Connection.isValid() API, which improves performance.

The HikariCP documentation strongly recommends that we do not set connectionTestQuery:

If your driver supports JDBC4 we strongly recommend not setting this property. This is for "legacy" drivers that do not support the JDBC4 Connection.isValid() API. This is the query that will be executed just before a connection is given to you from the pool to validate that the connection to the database is still alive. Again, try running the pool without this property, HikariCP will log an error if your driver is not JDBC4 compliant to let you know. Default: none

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud