search

maproulette / maproulette3

MapRoulette, the micro-tasking tool for OpenStreetMap
https://maproulette.org
MIT License
127 stars 34 forks source link

Preserve Overpass query when editing Challenge #236

Closed mvexel closed 6 years ago

mvexel commented 6 years ago

When you edit an existing Challenge based on an Overpass query, then save it, go back in and edit it again, the Overpass query is not displayed (or at least not in the case I just looked at, http://maproulette.org/mr3/admin/project/1/challenge/81/edit

mvexel commented 6 years ago

In another case http://maproulette.org/mr3/admin/project/1/challenge/222/edit it was in fact preserved.

nrotstan commented 6 years ago

PR #214 (in beta.3) makes some changes around how the data sources are managed when editing a challenge, and I think will address this issue. Let's retest once beta.3 is deployed.

mvexel commented 6 years ago

I'm thinking it may not be the overpass query, the challenge I mentioned in the initial ticket may have been created using local GeoJSON (upload). In any case, we should make that field less ambiguous when going back in and editing a challenge (see also #253, somewhat related). To discuss, what is the expected behavior if the source is changed after initial creation, or do we even want to allow that? I'm thinking it would be more straightforward to have the source field be immutable when going back in and editing the challenge.

nrotstan commented 6 years ago

It's true that for locally-uploaded GeoJSON, there is no display or information about the data when one goes back to edit the challenge. It'd be nice to at least display the filename of the file that was uploaded during creation (like we do after a fresh upload).

nrotstan commented 6 years ago

With PR #285, the source will no longer be modifiable once a challenge has at least one task. This should still allow modification if the tasks all fail to build due to, for example, a bad Overpass query. For challenges populated from a local GeoJSON upload, once the source becomes read-only the dropzone will be replaced with a message indicating that the existing file will be used.