maps-as-data / MapReader

A computer vision pipeline for exploring and analyzing images at scale
https://mapreader.readthedocs.io/en/latest/
Other
90 stars 11 forks source link

Add warning for downloading large amounts of data (more than 100MB(?)) #464

Closed rwood-97 closed 3 months ago

rwood-97 commented 3 months ago

Summary

This PR:

Fixes #444

Checklist before assigning a reviewer (update as needed)

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 72.94118% with 23 lines in your changes missing coverage. Please review.

Project coverage is 62.77%. Comparing base (f8b7c0f) to head (9fa8caf). Report is 3 commits behind head on main.

Files Patch % Lines
mapreader/download/downloader.py 13.04% 20 Missing :warning:
mapreader/download/sheet_downloader.py 85.71% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #464 +/- ## ========================================== - Coverage 62.83% 62.77% -0.07% ========================================== Files 41 41 Lines 6757 6807 +50 ========================================== + Hits 4246 4273 +27 - Misses 2511 2534 +23 ``` | [Flag](https://app.codecov.io/gh/Living-with-machines/MapReader/pull/464/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Living-with-machines) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Living-with-machines/MapReader/pull/464/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Living-with-machines) | `62.77% <72.94%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Living-with-machines#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.