maps-as-data / MapReader

A computer vision pipeline for exploring and analyzing images at scale
https://mapreader.readthedocs.io/en/latest/
Other
80 stars 11 forks source link

Rename "criterion" to "loss function" throughout code/docs #468

Closed rwood-97 closed 1 month ago

rwood-97 commented 1 month ago

Is your feature request related to a problem? Please describe. I am more used to hearing "loss function" used to describe the loss function/criterion used when training a model. Within our code we call this "criterion" which technically is correct but is less commonly used.

To avoid confusion it would be good to change the use of "criterion" to "loss_function" throughout the code and docs.

@kallewesterling @kmcdono2 do you agree with this?

kmcdono2 commented 1 month ago

Yes, let's make that change.

kallewesterling commented 1 month ago

Yep, in another package that I was working on, we used loss and loss_fn, see: