search

maps-as-data / MapReader

A computer vision pipeline for exploring and analyzing images at scale
https://mapreader.readthedocs.io/en/latest/
Other
80 stars 11 forks source link

print to logger #473

Closed rwood-97 closed 1 month ago

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.

Project coverage is 62.70%. Comparing base (9a7e36a) to head (bdb55d5).

Files Patch % Lines
mapreader/load/images.py 70.37% 8 Missing :warning:
mapreader/process/process.py 0.00% 2 Missing :warning:
mapreader/annotate/utils.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## kallewesterling/issue27 #473 +/- ## =========================================================== - Coverage 62.70% 62.70% -0.01% =========================================================== Files 41 41 Lines 6816 6824 +8 =========================================================== + Hits 4274 4279 +5 - Misses 2542 2545 +3 ``` | [Flag](https://app.codecov.io/gh/Living-with-machines/MapReader/pull/473/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Living-with-machines) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Living-with-machines/MapReader/pull/473/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Living-with-machines) | `62.70% <67.64%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Living-with-machines#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rwood-97 commented 1 month ago

@kallewesterling let me know about merging this into your branch. Will review yours after

kallewesterling commented 1 month ago

@rwood-97 Can't remember what we said about this one but I think we should just go ahead and merge the two of them, right?

rwood-97 commented 1 month ago

I'm going to do the debug thing, will do now

rwood-97 commented 1 month ago

Ah wait no, some of the messages are actually warnings and some are info. So both being debug seems confusing. Maybe I'll merge it and we can work out from the other branch?

kallewesterling commented 1 month ago

Ah wait no, some of the messages are actually warnings and some are info. So both being debug seems confusing. Maybe I'll merge it and we can work out from the other branch?

SOrry - only now saw this! Yeah, let's merge this and then we'll do any further edits on the other branch.