maps-as-data / MapReader

A computer vision pipeline for exploring and analyzing images at scale
https://mapreader.readthedocs.io/en/latest/
Other
90 stars 11 forks source link

Better use of geopandas in MapReader #495

Closed rwood-97 closed 1 month ago

rwood-97 commented 2 months ago

Summary

At the moment MapReader doesn't make full use of geopandas. This PR addresses this and brings in geopandas wherever possible into the MapReader pipeline.

Fixes #436 Fixes #467

Describe your changes

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

review-notebook-app[bot] commented 2 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 91.28788% with 92 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
mapreader/download/sheet_downloader.py 79.38% 27 Missing :warning:
mapreader/spot_text/runner_base.py 0.00% 24 Missing :warning:
mapreader/spot_text/deepsolo_runner.py 0.00% 8 Missing :warning:
mapreader/spot_text/dptext_detr_runner.py 0.00% 8 Missing :warning:
mapreader/spot_text/maptext_runner.py 0.00% 8 Missing :warning:
tests/test_classify/test_datasets.py 94.11% 4 Missing :warning:
mapreader/classify/load_annotations.py 81.25% 3 Missing :warning:
mapreader/download/downloader.py 0.00% 3 Missing :warning:
mapreader/classify/datasets.py 93.33% 2 Missing :warning:
mapreader/load/images.py 98.36% 2 Missing :warning:
... and 2 more
Flag Coverage Δ
unittests 68.56% <91.28%> (+2.52%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mapreader/download/tile_merging.py 77.94% <100.00%> (+1.88%) :arrow_up:
mapreader/process/occlusion_analysis.py 99.21% <100.00%> (-0.02%) :arrow_down:
mapreader/utils/load_frames.py 100.00% <100.00%> (ø)
tests/test_annotate/test_annotator.py 100.00% <100.00%> (ø)
tests/test_classify/test_annotations_loader.py 100.00% <100.00%> (ø)
tests/test_download/test_sheet_downloader.py 99.77% <100.00%> (+<0.01%) :arrow_up:
tests/test_load/test_images.py 100.00% <100.00%> (ø)
tests/test_load/test_images_load_parents.py 100.00% <100.00%> (ø)
tests/test_load/test_loader.py 100.00% <100.00%> (ø)
tests/test_load/test_loader_load_patches.py 100.00% <100.00%> (ø)
... and 15 more

... and 1 file with indirect coverage changes

rwood-97 commented 1 month ago

@kallewesterling how do you feel if merge this? I feel pretty sure it won't break anything (and we can always revert to previous version if there is an issue) and will be helpful for the Oct workshop with visualising text outputs.