Closed rwood-97 closed 1 month ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Attention: Patch coverage is 91.28788%
with 92 lines
in your changes missing coverage. Please review.
Flag | Coverage Δ | |
---|---|---|
unittests | 68.56% <91.28%> (+2.52%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files with missing lines | Coverage Δ | |
---|---|---|
mapreader/download/tile_merging.py | 77.94% <100.00%> (+1.88%) |
:arrow_up: |
mapreader/process/occlusion_analysis.py | 99.21% <100.00%> (-0.02%) |
:arrow_down: |
mapreader/utils/load_frames.py | 100.00% <100.00%> (ø) |
|
tests/test_annotate/test_annotator.py | 100.00% <100.00%> (ø) |
|
tests/test_classify/test_annotations_loader.py | 100.00% <100.00%> (ø) |
|
tests/test_download/test_sheet_downloader.py | 99.77% <100.00%> (+<0.01%) |
:arrow_up: |
tests/test_load/test_images.py | 100.00% <100.00%> (ø) |
|
tests/test_load/test_images_load_parents.py | 100.00% <100.00%> (ø) |
|
tests/test_load/test_loader.py | 100.00% <100.00%> (ø) |
|
tests/test_load/test_loader_load_patches.py | 100.00% <100.00%> (ø) |
|
... and 15 more |
@kallewesterling how do you feel if merge this? I feel pretty sure it won't break anything (and we can always revert to previous version if there is an issue) and will be helpful for the Oct workshop with visualising text outputs.
Summary
At the moment MapReader doesn't make full use of geopandas. This PR addresses this and brings in geopandas wherever possible into the MapReader pipeline.
Fixes #436 Fixes #467
Describe your changes
SEE CHANGELOG
Checklist before assigning a reviewer (update as needed)
[x] Self-review code
[x] Ensure submission passes current tests
[x] Add tests
[x] Update relevant docs
[x] Update changelog
Reviewer checklist
Please add anything you want reviewers to specifically focus/comment on.