search

maps-as-data / MapReader

A computer vision pipeline for exploring and analyzing images at scale
https://mapreader.readthedocs.io/en/latest/
Other
89 stars 10 forks source link

Review and plan response to `scikit-learn-intelex` installation notice. #85

Open andrewphilipsmith opened 1 year ago

andrewphilipsmith commented 1 year ago

When installing dependencies, via conda the following message is displayed:

    Installed package of scikit-learn can be accelerated using scikit-learn-intelex.
    More details are available here: https://intel.github.io/scikit-learn-intelex

    For example:

        $ conda install scikit-learn-intelex
        $ python -m sklearnex my_application.py

It is unclear whether this is: a) compatible with MapReader b) is beneficial to MapReader c) the responsibility of MapReader developers to incorporate this into the package, or the responsibility of end users to setup their system optimally. d) best ignored/ e) If best ignored, if it is possible to suppress this message?

kallewesterling commented 4 months ago

@rwood-97 Do you think this one needs revisiting? Have you noticed any trouble running MapReader with this problem?

rwood-97 commented 4 months ago

We've removed the conda install option from our docs since it was outdated and buggy. I think we should focus on #162 first and make sure mapreader is installable with conda, then see if that fixes this issue.

This isn't an issue with pip though