search

mapsense / mapsense.js

Mapsense.js
Other
88 stars 22 forks source link

classify() and selection() #3

Closed sttawm closed 9 years ago

sttawm commented 9 years ago

I've just checked out the latest polymaps and have a few suggestions. Let me know what you think.

  1. D3Topojson.classify() seems general enough to go in D3Geojson
  2. When using D3Topojson, the logic to render each feature separately seems a bit too involved given the likelihood that the user would want to do so -- (it involves configuring topologyFeatures). It'd be nice to make this simpler. How about we provide a static function to pass into topologyFeatures()? Another option is to just pass null, or to add a separate method with a better name than dontGroup. EDIT: I completely misread the code.
  3. Willy has alerted me that selection() does not re-apply to the selection when re-invoked. Is reshow() the preferred method? How about automatically reapplying the selection function to all visible tiles when it is reinvoked?
mpruett commented 9 years ago

D3Topojson.classify() seems general enough to go in D3Geojson

Yes I'll move it there.

mpruett commented 9 years ago

Willy has alerted me that selection() does not re-apply to the selection when re-invoked. Is reshow() the preferred method? How about automatically reapplying the selection function to all visible tiles when it is reinvoked?

That is the intended behavior. I'll figure out what's going wrong.