mapsme / omim

🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android
Apache License 2.0
4.56k stars 1.15k forks source link

Mapcode recognized as phone number #11342

Open thany opened 5 years ago

thany commented 5 years ago

Consider this text in a bookmark description:

Mapcode: 592 319 072*14

The app will underline the 592 319 072 part. This is useless, because it's not a phone number, and I verified: tapping it makes my phone try to call that number.

If you don't know, Denso Mapcode is a proprietary "simplified" mapping scheme for Japanese car natsavs.

I would prefer if the app didn't auto-underline phone numbers at all in the description box. Maybe you can add a setting for it.

burivuh commented 4 years ago

Hi! OS version and a phone model, please. Thanks.

thany commented 4 years ago

Galaxy S9, Android 8.1

Why is this needed? Is this not handled by the app?

burivuh commented 4 years ago

No, we use system functions to render html content.

thany commented 4 years ago

But it isn't html... It's just plain text, isn't it?

burivuh commented 4 years ago

No, our descriptions supports HTML, so every description is treated that way.

thany commented 4 years ago

Okay, so if it's HTML, you shouldn't magically turn things into links. HTML can do that already.

On a sidenote: What masochist types in HTML on their phone? I would much prefer markdown, which requires a lot fewer characters from the secondary keyboard, and can fully serve (what I assume are) the usecases for HTML is a description. But that's a different story.

burivuh commented 4 years ago
  1. As I've said, we do not create links directly. So we need to investigate.
  2. There's plenty of people that creates bookmarks on web and then import them into Maps.Me
thany commented 4 years ago

Okay, fair enough. For your investigation, there are a LOT more kinds of numbers that are incorrectly recognized as phone numbers. So the problem isn't specific to mapcodes. I've seen this happening with prices, where it even has a currency sign before the number.

Mapcodes may look most like a phone number without being one, so perhaps you can take that as the most challenging usecase.

thany commented 4 years ago

Aaaand..?

thany commented 4 years ago

Aaaaaaand..?

thany commented 3 years ago

Aaaaaaaaaaaaaaaaaaand..?

thany commented 3 years ago

Also I'm on a Galaxy S9 still, but upgraded to Android 10. Issue persists.