mapsme / subways

Subway Preprocessor and Validator
Apache License 2.0
28 stars 11 forks source link

Unclear error being issued #38

Open ghost opened 6 years ago

ghost commented 6 years ago

http://osmz.ru/subways/usa.html

Stop "190th Street" (pos) is nowhere near the tracks (relation 366774, "NYCS - A Train")

Doesn't make sense because node is on tracks. Also, should report the node rather than node's coordinates.

Zverik commented 6 years ago

The thing is, a stop's location is calculated based on all features that it contains, including stop positions, platforms, stations etc. So there might be no object at that location. Regarding the error, try sorting and cleaning up ways in the route, after that it would be clearer.

ghost commented 6 years ago

http://osmz.ru/subways/usa.html

Stop "50th Street" (pos) is nowhere near the tracks (relation 366774, "NYCS - A Train")

Station is a node that is part of the track. Yet, it is still getting an error.

No stop area relations. Three subway routes, all which have relations both with the track and with station node.

And if you plot the position, of the (pos), it is right on top of the track.

This issue seems to happen over an over again for station nodes built into tracks. Stations nodes should not be getting error flags for being built into the tracks that contain the route.

ghost commented 6 years ago

Issue is also happening with subway stopping location nodes that are nodes in tracks that form part of subway route relation, e.g. New York

Stop "125th Street" (pos) is nowhere near the tracks (relation 366774, "NYCS - A Train") https://www.openstreetmap.org/search?query=40.8107448%2C-73.9525764#map=18/40.81074/-73.95258 https://www.openstreetmap.org/node/2013622912#map=19/40.81063/-73.95186

alexey-zakharenkov commented 5 years ago

Such error message also can appear if the route track line is torn. In this case the longest continuous line is taken by validator as "tracks". The track segments in the route should be sorted first.