mapsme / subways

Subway Preprocessor and Validator
Apache License 2.0
28 stars 11 forks source link

Are you going to add networks that are light rail only? #50

Closed claudiush closed 6 years ago

claudiush commented 6 years ago

There is "S-Bahn Mitteldeutschland" in the Leipzig-Halle region in Germany with 10 lines and 141 stations. Including a tunnel section under the city center: https://en.wikipedia.org/wiki/S-Bahn_Mitteldeutschland None of the infrastructure is subway, but everything light rail. Are you intending to support these networks as well? If yes: How would I request it to be added to the spreadsheet?

Zverik commented 6 years ago

Of course, any railway-based network that has stations would do, even trains. I would need a value for all the cells in a new row: city, bounding box, number of lines, stations and interchanges.

claudiush commented 6 years ago

Great. Two comments:

Here's the details you asked for: name: S-Bahn Mitteldeutschland bbox: 11.907233,50.698847,14.257053,51.869652 lines: 10 light rail lines stations: 141 interchanges: 3 network: Mitteldeutscher Verkehrsverbund

Zverik commented 6 years ago

When a bounding box contains multiple networks (Leipzig S-Bahn and Dresden S-Bahn in this case), please use network tags on routes and route_masters to separate these. When it's not possible (like in Germany), use network:metro=*.

claudiush commented 6 years ago

Perfect. The network tags are already set on the routemasters for both the Dresden and Leipzig-Halle S-Bahns.

So here's the details for Dresden then:

name: Dresden S-Bahn bbox: 13.343266,50.875153,14.235952,51.165517 lines: 3 light rail lines stations: 48 interchanges: 1 network: VVO

Zverik commented 6 years ago

The validator will finish in half an hour, you'll see the results here: http://osmz.ru/subways/germany.html

claudiush commented 6 years ago

Similar problem as with Nuremburg it seems: There are various regional trains that are also operating in the same network. I've started adding network:metro=s-bahn to the routes and masters. @Zverik Can you add this additional network restriction for both Dresden and Leipzig, please?

Zverik commented 6 years ago

Did that just now and started the validator. You will see the results in an hour.

claudiush commented 6 years ago

Thanks.

Seems there's a slight problem since Leipzig/Halle and Dresden S-Bahn networks are overlapping. I therefor currently see Dresden S-Bahn routes listed for Leipzig/Halle.

Can you make a logical AND a requirement for route networks, e.g. the following requirements:

Zverik commented 6 years ago

Is it an option to use dresden s-bahn for routes in Dresden? Maybe it can be solved by making bboxes smaller — I'll look into this later.

claudiush commented 6 years ago

The Leipzig network has one line which is reaching very far East and ends northeast of Dresden. Also it reaches very far South which leads to the Leipzig bbox encompassing the Dresden network in large parts.

I've just re-tagged the Dresden routes to Dresden: network=VVO && network:metro=S-Bahn Dresden

claudiush commented 6 years ago

And while we are at it here's another light rail network in Magdeburg:

name: S-Bahn Mittelelbe bbox: 11.617733,51.997556,11.868564,53.00376 lines: 1 light rail line stations: 28 interchanges: 0 network: Magdeburger Regionalverkehrsverbund network:metro=s-bahn

This should be more straight forward without any overlapping neighbouring networks

Zverik commented 6 years ago

Added it, under name "Magdeburg S-Bahn". I know the name is not exactly correct, but it helps with identifying the central city for the route.