mapsplugin / cordova-plugin-googlemaps

Google Maps plugin for Cordova
Apache License 2.0
1.66k stars 913 forks source link

InterruptedException to Exception change #2909

Open michal-szklarski-jmp opened 1 year ago

michal-szklarski-jmp commented 1 year ago

We're observing the enormous number of crashes (coming mostly from Firebase's stack trace) in PluginMarker.java file. The line 167 is generating an Exception that is not being predicted by the Try-Catch where is inserted (lines 149 - 185), which is specifically only catching InterruptedException types. Simply replacing "InterruptedException" with "Exception" will solve the problem, as then the catch will be able to catch all Exception types and avoid the crash.

Pull request guide

Thank you for considering to improve this cordova-plugin-googlemaps.

When you create a pull request, please make it to multiple_maps branch instead of master branch.

Because the multiple_maps branch is edge version.

Thank you for your understanding.