Search Form collapses when using spacebar

mapsteps / page-builder-framework

52 stars 17 forks source link

Search Form collapses when using spacebar #23

Closed gbruzzo closed 5 years ago

gbruzzo commented 5 years ago

Hi there @MapSteps

could you please check if you can reproduce the following UI problem:

search form enabled in header (mobile or desktop, it doesn't matter)
enter a search word, followed by space (hitting the space bar).
the form collapses.

Thanks in advance for any comments (we currently run another framework for search, but, but as we tested with regular search, we observed this problem)

Cheers

Giacomo

mapsteps commented 5 years ago

Hi @gbruzzo,

what browser are you using? I wasn't able to replicate this in Firefox.

Best, David

mapsteps commented 5 years ago

grafik

gbruzzo commented 5 years ago

hello @MapSteps!

the issue does not happen in non-mobile navigation. It happens with mobile navigation (in our case with hamburger). Can you try and replicate?

Giacomo

gbruzzo commented 5 years ago

Hypothesis:

the keyboard action that causes the offcanvas to close also causes the search form to close.

Giacomo

gbruzzo commented 5 years ago

Hello @MapSteps

hope all well. Touching base because I heard nothing back from you - the search field does indeed collapse upon pressing the spacebar, on the mobile. I can do a video if you wish.

Please advise

Giacomo Bruzzo

mapsteps commented 5 years ago

Hi @gbruzzo,

sorry for the delay here. I was able to reproduce this and we're going to look into this.

Thanks for reporting!

mapsteps commented 5 years ago

Fixed :) https://github.com/MapSteps/Page-Builder-Framework/commit/41d976cf4820c040256ee968c0d6685b3ef1f602