mapsteps / page-builder-framework

52 stars 17 forks source link

sticky menu width cannot be properly controlled #27

Closed gbruzzo closed 4 years ago

gbruzzo commented 4 years ago

Hi there @MapSteps

in the customizer you can set page to have a max-width). This setting can be applied to layout, header, footer, navigation (and shop).

if you have a sticky menu though and scroll down, you will notice that the menu becomes suddenly 100% wide. (wpbf-navigation width is set to 100% in style.css)

You can override wpbf-navigation for the sticky menu, by setting width or max width. I am finding it hard though to force the sticky header to be correctly left aligned.

Do you have any suggestions?

Thanks in advance for the consideration

Giacomo

mapsteps commented 4 years ago

Hi Giacomo,

Are you looking for a separate width control for the sticky navigation? I just want to make sure we're on the same page. If that's the case, let's do this :)

PS: For feature requests or issues involving the Premium Add-On, please create a ticket under - https://wp-pagebuilderframework.com/support/. That will allow us to organize things better & help resolve issues faster.

Thanks! :)

gbruzzo commented 4 years ago

Hello there!

In essence I was looking at controlling the width and placement of the header - if I set width (boxed or not) at a given px, I would like the header (and footer) to be that wide and not more.

Having - I am currently working with all values set at 100% - so I am looking for options should I change ideas in future.

Giacomo

On Sat, 18 Jan 2020 at 20:09, David Vongries notifications@github.com wrote:

Hi Giacomo,

Are you looking for a separate width control for the sticky navigation? I just want to make sure we're on the same page. If that's the case, let's do this :)

PS: For feature requests or issues involving the Premium Add-On, please create a ticket under - https://wp-pagebuilderframework.com/support/. That will allow us to organize things better & help you resolve issues faster.

Thanks! :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MapSteps/Page-Builder-Framework/issues/27?email_source=notifications&email_token=AEAFD6QOJD7IUUFWJ3TAGJDQ6NOV5A5CNFSM4KEZO2TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKA5AA#issuecomment-575934080, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEAFD6UDZ4AF5AHQDBMAMYLQ6NOV5ANCNFSM4KEZO2TA .

mapsteps commented 4 years ago

Okay, let me ask again so I'm 100% sure we're on the same page.

As an example, let's imagine we've set the header on the WooCommerce Shop page to 1000px. On that particular page, you'd want the sticky navigation to inherit the regular navigation width, is that correct?

Currently the sticky nav is independent and doesn't respect those values set for the regular navigation.

Sorry for the confusion!

David

gbruzzo commented 4 years ago

submitting a ticket now

gbruzzo commented 4 years ago

Done, pls close this