search

mapstruct / mapstruct-eclipse

An Eclipse plug-in for working with MapStruct
Other
13 stars 8 forks source link

#1 Providing initial project layout and MapStruct Eclipse plug-in with content assist functionality #2

Closed wetzer closed 9 years ago

wetzer commented 9 years ago

Hi @gunnarmorling, finally here is my suggestion for a Tycho-built MapStruct Eclipse plug-in that provides content assist.

gunnarmorling commented 9 years ago

Wow, that's awesome, @larswetzer! Going to look at it asap.

gunnarmorling commented 9 years ago

Giving it a test run as we speak. Works like charm, just awesome :+1: :+1: :+1: !

gunnarmorling commented 9 years ago

@larswetzer This looks fantastic overall; only added some minor remarks inline.

I didn't fully grok all the code in the proposal computer, could you maybe add a short comment to the methods (no need for full param/return value description)?

Thanks a lot for this great contribution! Looking forward to the plug-in very much :-)

gunnarmorling commented 9 years ago

Created #7 as a follow-up for some more auto-completions.

wetzer commented 9 years ago

Thanks for your review! Very good points. I'll have a look at it shortly.

agudian commented 9 years ago

Awesome idea and I bet it will be a hit! :+1:

wetzer commented 9 years ago

Thank you both!

Rebased the fixes. @gunnarmorling could you please have a look at it again.

gunnarmorling commented 9 years ago

Merged. Many, many thanks, @larswetzer! That's fantastic!