search

mapstruct / mapstruct-examples

Examples for using MapStruct
Other
1.28k stars 511 forks source link

checkstyle fails on mapper generated implementations #108

Closed noah-iam closed 11 months ago

noah-iam commented 3 years ago

I love this mapstruct. I am using the 1.4.0.beta version . So , checkstyle is failing in autogenerated mapper impl

<module name="WhitespaceAfter">

Description: When mapstruct is generating the source code, it doesn't follow the checkstyle rules .

Solution: Although, I have suppressed the error by marking mapper implementation folder checks none but can someone take it on?

thunderhook commented 11 months ago

@noah-iam Is this still an issue? It seems like this is a configuration issue of checkstyle with generated sources, see https://stackoverflow.com/a/48618394 for example.

filiphr commented 11 months ago

Thanks for checking this one @thunderhook. To add a bit more info. There is https://github.com/mapstruct/mapstruct/issues/877 which is about using a custom formatter to format the generated code. It hasn't been done since it is not the most trivial.

I'll close this in favor of https://github.com/mapstruct/mapstruct/issues/877