search

mapstruct / mapstruct-examples

Examples for using MapStruct
Other
1.28k stars 511 forks source link

Fix breaking change from lombok 1.18.16 #111

Closed guillaumeyan closed 3 years ago

guillaumeyan commented 3 years ago

Fix https://github.com/mapstruct/mapstruct-examples/issues/110

filiphr commented 3 years ago

Thanks for the PR @guillaumeyan.

I knew about this change, but didn't upgrade the examples due to https://github.com/rzwitserloot/lombok/issues/2616. As you can see the JDK 1.8 build is failing, this is due to the fact the the Lombok MapStruct binding is compiled with Java 9, which leads to Lombok and MapStruct no longer working on Java 8.

I would wait on the Lombok issue before merging this.

filiphr commented 3 years ago

Fixed as part of https://github.com/mapstruct/mapstruct-examples/pull/113