filiphr
commented
2 years ago Thanks for the PR @Celebrate-future. I do not agree that this PR makes sense for the examples. This is an example that is using the recommendations by the Kotlin team and adding the dependencies that a Kotlin project will have.
Adding exclusions like you are suggesting might confuse people and will go in a direction opposite of what Kotlin itself is proposing.
Can you please tell us how you did your analysis? It seems to me like this PR has been created in an automated way. If this is the case, then It is really not fair to Open Source maintainers to do these things.
Redundant dependencies
org.jetbrains.kotlin:kotlin-stdlib-common:jar:1.5.10:compile org.jetbrains.kotlin:kotlin-test-junit:jar:1.5.10:test org.jetbrains:annotations:jar:13.0:compile
Removing the redundant dependencies can reduce the size of project and prevent potential dependency conflict issues (i.e., multiple versions of the same library). More importantly, As such, I suggest a refactoring operation for org.mapstruct.examples.kotlin:mapstruct-examples-kotlin:1.0.0-SNAPSHOT’s pom file.
As shown in the figure, it is noteworthy that, libraries org.jetbrains.kotlin:kotlin-test::1.5.10:test(130KB) are invoked by the projects. When we remove the redundant dependency org.jetbrains.kotlin:kotlin-test-junit::1.5.10:test, the above org.jetbrains.kotlin:kotlin-test::1.5.10:test(130KB) should be declared as direct dependencies. The attached PR helps resolve the reported problem. It is safe to remove the unused libraries (we considered Java reflection relations when analyzing the dependencies). These changes have passed org.mapstruct.examples.kotlin:mapstruct-examples-kotlin:1.0.0-SNAPSHOT’s maven tests.
Best regards