search

mapstruct / mapstruct-examples

Examples for using MapStruct
Other
1.3k stars 508 forks source link

Wrap all examples into one parent maven #18

Closed filiphr closed 7 years ago

filiphr commented 7 years ago

This could be good for better version control, we'll need to update one property instead of all around 😄

gunnarmorling commented 7 years ago

Centralizing the version sounds good, but I'd prefer to not aggregate things further, i.e. let's not pull up common plug-ins etc. The reason being that the examples should be as self-contained as possible.

agudian commented 7 years ago

We could also leave the mapstruct-version in the respective poms and not use a real parent pom, but only add an aggregator pom at top-level. That allows us to create a proper PullRequestBuilder and we can use mvn versions:update-version... to update the version-property in all poms in one go...

agudian commented 7 years ago

uhm, with the exception of the ant and gradle examples... 😁

gunnarmorling commented 7 years ago

Yes, a plain aggregator would be my preference.

agudian commented 7 years ago

Done.