search

mapstruct / mapstruct-idea

An IntelliJ IDEA plugin for working with MapStruct
Other
141 stars 38 forks source link

Fixes issue #121 #122

Closed andye2004 closed 1 year ago

andye2004 commented 1 year ago

Please note, the fix in this PR only fixes the issue for those occasions where buidlers are disabled.

filiphr commented 1 year ago

Thanks for the PR @andye2004. However, I will have to reject it. The reason why MapStruct doesn't consider the get method as a fluent setter is not because of the fact that you have disabled the builder. It doesn't consider it because the method return type (Object) is not assignable to the target type (ToyCar).

andye2004 commented 1 year ago

@filiphr no worries, I note that you agree that #121 is a bug, albeit it requires a different fix so so have no issue with the PR being rejected.