search

mapstruct / mapstruct-idea

An IntelliJ IDEA plugin for working with MapStruct
Other
141 stars 38 forks source link

#151 rework inheritance and support auto inheritance #152

Closed thunderhook closed 1 year ago

thunderhook commented 1 year ago

See #151. This took me a while to figure out how the inheritance is handled by MapStruct.

Fixes #151

thunderhook commented 1 year ago

Thank you for having a look at the PR @filiphr. I hope you had a great and relaxing vacation! If you find any problems during testing this on some real world projects, let me know. I made some random checks on the Mappers inside the tests of the Mapstruct main project. There I stumbled accross the issue with referenced mappers. 🙂

I will resolve your comments and questions in the evening. 👍

thunderhook commented 1 year ago

@filiphr You can now have another look at the PR when you find time. Thanks alot!

Sidenote: Reached out to you by mail. Maybe check your spam folder, because I used an emoji in the subject... 🤦 😅

filiphr commented 1 year ago

Thanks a lot for the improvements you did for the configuration inheritance.