search

mapstruct / mapstruct-idea

An IntelliJ IDEA plugin for working with MapStruct
Other
141 stars 38 forks source link

add idea 2024.1 to build matrix #189

Closed hduelme closed 7 months ago

hduelme commented 7 months ago

Added latest released version to build matrix

hduelme commented 7 months ago

I also update codecov/codecov-action to v3. The old version failed to upload.

thunderhook commented 7 months ago

@hduelme Thanks.

Interestingly now v3 seems to fail when uploading it. Any idea why that happens?

hduelme commented 7 months ago

@thunderhook yes it's a known issue of codecov see https://github.com/codecov/codecov-action/issues/598

Seems like they published a v4 to address this issue.

hduelme commented 7 months ago

One thing to not is that tokenless uploading is no longer supported in v4. If the project currently doesn't have a token see https://docs.codecov.com/docs/adding-the-codecov-token#github-actions

thunderhook commented 7 months ago

Thanks @hduelme

I will merge this for now. @filiphr have a look at what @hduelme wrote about the codecov token. I don't know if you have anything to do with it.

thunderhook commented 7 months ago

OK, next time I'll leave the merge to you @filiphr 😅

Pipeline looked good (see details above) and everything went fine:

The main branch can't upload the coverage report now due to the missing token:

So we'll have to add a token now.

filiphr commented 7 months ago

@thunderhook I've added the token in 4fa44fbeadb303c9f458d8449433bfa267e71a57. However, it seems like the coverage is now 0 (https://app.codecov.io/github/mapstruct/mapstruct-idea). Perhaps something is not correct with what Jacoco generates