search

mapstruct / mapstruct-idea

An IntelliJ IDEA plugin for working with MapStruct
Other
141 stars 38 forks source link

Prepare for IntelliJ 2024.2 cycle #195

Closed unshare closed 2 days ago

unshare commented 5 months ago

Thanks for your work on this @unshare. I see that this is still in Draft. Do you think that it is ready for merging? All the tests look OK and the changes are also OK.

A the moment I'm awaiting https://github.com/JetBrains/intellij-plugin-verifier/pull/1097/ to be merged. It will probably fix "old" (1.x) org.jetbrains.intellij plugin being unable to parse Kotlin plugin's descriptor.

A better approach would be migrate to "new" (2.x) IntelliJ Platform Plugin SDK, but it's too much for the time being.

Merging without working 2024.2 support kind of defeats the purpose of this PR.

unshare commented 5 months ago

@filiphr Look, I'm doing a spring cleanup for all the stuff I personally deem necessary at the moment. When the list of changes is ~complete, I'd update both commit message and PR description as well. The PR will be un-drafted as well.

Given I'm the one who did the cleanup around Gradle the last time 1.5 years ago, it looks like I'm the only one who cares about Gradle. Kind of makes me maniac. Well, no. I'm a downstream consumer, so I'm kind of involved and engaged as required.

As for everything else, it looks like tests pass with a certain mockJDK versions by JetBrains and fail ridiculously with the regular way to obtain and exploit the mocks intended for the particular version of the IDE. That's something to be contemplated about.

Please, don't hesitate to tell me to piss off with the changes I propose, but please do so granularly and reasonably.

And yes, this is still a draft.

unshare commented 5 months ago

If you're okay with switching from Gradle Groovy DSL to Kotlin DSL, just give me a go ahead.

filiphr commented 4 months ago

Hey @unshare,

Just wanted to share with you PR https://github.com/mapstruct/mapstruct-idea/pull/202. We upgraded the baseline to Java 17. Giving you the heads up as your PR also is doing that 😄.