search

maptiler / tileserver-gl

Vector and raster maps with GL styles. Server side rendering by MapLibre GL Native. Map tile server for MapLibre GL JS, Android, iOS, Leaflet, OpenLayers, GIS via WMTS, etc.
https://tileserver.readthedocs.io/en/latest/
Other
2.24k stars 639 forks source link

broken docker image maptiler/tileserver-gl-light:v4.6.3 #1042

Closed albanm closed 1 year ago

albanm commented 1 year ago

It is missing the node exec and node_modules directory at least.

$ docker run -it --rm maptiler/tileserver-gl-light:v4.6.3
/usr/src/app/docker-entrypoint.sh: 4: exec: node: not found
albanm commented 1 year ago

The Dockerfile is missing apt-get install -y nodejs;.

Also the npm ci instruction is ran inside a series of commands separated by ";" instead of "&", which probably explains why it failed but did not break the image build.

acalcutt commented 1 year ago

I didn't realize i broke this when i was troubleshooting why the npm ci was failing on arm.

If you want to submit a PR to fix this it will help me approve it easier.

albanm commented 1 year ago

Sure, I will prepare a PR.

albanm commented 1 year ago

Is it on purpose that Dockerfile_light references docker-entrypoint.sh and not docker-entrypoint_light.sh ?

acalcutt commented 1 year ago

Nevermind, I just fixed is manually, so a pr should not be needed unless you think more changes should be made.

And yes, the name is on purpose. when the publish.js script copies files it renames this file https://github.com/maptiler/tileserver-gl/blob/master/publish.js#L51

albanm commented 1 year ago

Ok, thanks !

acalcutt commented 1 year ago

v4.6.5 light version should be fixed