maputnik / osm-liberty

A free Mapbox GL basemap style for everyone
Other
435 stars 99 forks source link

Wetlands styling #70

Closed kylebarron closed 1 year ago

kylebarron commented 4 years ago

I noticed some disconnected streams (center of image), and discovered that it's because wetlands aren't currently given any styling. https://maputnik.github.io/editor/#15.27/44.10019/-71.576018 image

This is defined as class=wetlands within landcover in the OpenMapTiles schema (And as natural=wetland within OSM): image

The default OSM basemap uses a custom pattern: image

Should these polygons be given a style in OSM Liberty, and if so, what should it be?

pathmapper commented 4 years ago

Nice find @kylebarron

Should these polygons be given a style in OSM Liberty, and if so, what should it be?

Yes, we should style these. Currently we are using only a pattern for the road_area_pattern, for wetlands maybe using a light plain color or a sparse pattern which is less obtrusive?

Open for suggestions.

kylebarron commented 4 years ago

Maki does have a wetland icon: https://github.com/mapbox/maki/blob/master/icons/wetland-11.svg

It doesn't look very good to just add the wetland icon in the current sprite: image

A simple wetland icon without the bordering circle might look good, but I haven't figured out how to edit the sprite yet.

pathmapper commented 4 years ago

There is a Maki editor: https://labs.mapbox.com/maki-icons/editor/ Or you could use https://inkscape.org to modify the SVG.

There is no need that it would be part of the iconset, because it is no POI. We are having also SVGs which are not part of the iconset, like the fill pattern for the pedestrian_polygon: https://github.com/maputnik/osm-liberty/tree/gh-pages/svgs/svgs_not_in_iconset

pathmapper commented 4 years ago

from: https://docs.mapbox.com/mapbox-gl-js/style-spec/#paint-fill-fill-pattern

For seamless patterns, image width and height must be a factor of two (2, 4, 8, ..., 512)

pathmapper commented 4 years ago

I haven't figured out how to edit the sprite yet

You could use https://github.com/mapbox/spritezero-cli, it is described here (bottom of that page): https://github.com/maputnik/osm-liberty#icon-design

jpbede commented 4 years ago

What do you say about that ?

image

pathmapper commented 4 years ago

Hey @jpbede, thanks, looks promising!

Would you like to submit a PR so we could evaluate how the pattern behaves for different zoom levels?

jpbede commented 4 years ago

Sure. Created the PR 84