mapzen / android

Where you can find everything Android from Mapzen
http://mapzen.github.io/android/
Apache License 2.0
118 stars 66 forks source link

Deploy Stylesheets #489

Closed sarahsnow1 closed 6 years ago

sarahsnow1 commented 6 years ago

Overview

This is an exciting change to the SDK. With this work, all house stylesheets are now deployed as separate artifacts which means that developers can optionally exclude or include them on an as-needed basis.

compile 'com.mapzen:bubble-wrap:$VERSION_NUMBER'
compile 'com.mapzen:cinnabar:$VERSION_NUMBER'
compile 'com.mapzen:refill:$VERSION_NUMBER'
compile 'com.mapzen:tron:$VERSION_NUMBER'
compile 'com.mapzen:walkabout:$VERSION_NUMBER'

By default, the SDK includes the same four it always has (bubble-wrap, cinnabar, refill, and walkabout). But now tron is also deployed and can be included.

Proposed Changes

Closes #486

matteblair commented 6 years ago

From the description it looks like the scene file artifacts are going to use the same version number as the SDK, but I wonder if this would get confusing since the cartography assets already have their own versioning: https://mapzen.com/documentation/cartography/versioning/

sarahsnow1 commented 6 years ago

I thought about keeping the scene file artifact version numbers consistent with the cartography releases but decided not to primarily because I wanted implementing developers to not have to think about which artifact version to use with any given version of the SDK. I think that most developers don't care which version of the cartography release they are using, they will just want the latest as quickly as possible. I also don't want to be tied directly to the cartography release versions so that if in the future we have to add code or files to one of these artifacts, it doesn't break the artifact release versioning.