Multi Modal can get into a state where routes disappear that were originally there

mapzen / eraser-map

Privacy-focused mapping application for Android

GNU General Public License v3.0

74 stars 24 forks source link

Multi Modal can get into a state where routes disappear that were originally there #698

Closed msmollin closed 8 years ago

msmollin commented 8 years ago

Device name: OnePlus One
Android Version: 6.0.1
App build number: 0.10.2
What did you expected to happen? When tapping quickly between route versions (Car -> Bike -> Car -> etc.) the routes should remain accurate.
What happened instead? After enough tapping the bike route disappeared. Toggling slowly brought it back.
Steps to reproduce: Load a route that has both car and biking directions, and quickly tap between the two options.
Attach a screenshot

sarahsnow1 commented 8 years ago

I've been tapping like a maniac and can't repro this. I looked at the code and can see we are "cancelling" requests each time a new route mode is clicked. @ecgreb can you see anything I'm missing in the code?

ecgreb commented 8 years ago

I am also unable to reproduce.

We did implement pseudo-cancellation when toggling between routing modes in that if a new request is made before the original request completes then the result of the original request is ignored.

https://github.com/mapzen/eraser-map/pull/631

msmollin commented 8 years ago

Here's me reproducing it on my Nexus 7.

https://www.youtube.com/watch?v=KaUBCI2gKyc

ecgreb commented 8 years ago

I was just now able to reproduce. Not only route line but pins also disappeared after rapidly switching modes several times.

Possibly related to https://github.com/mapzen/eraser-map/issues/705?

mjcunningham commented 8 years ago

I motion to close this in favor of https://github.com/mapzen/eraser-map/issues/705

If anyone opposes you can re-open this.