Map pins cover map marker / POIs

mapzen / eraser-map

Privacy-focused mapping application for Android

GNU General Public License v3.0

74 stars 24 forks source link

Map pins cover map marker / POIs #762

Closed msmollin closed 7 years ago

msmollin commented 7 years ago

Device name: Nexus 5
Android Version: 4.4.4
App build number: master-1795
What did you expected to happen? When I tapped on a map marker, a pin would appear with the pin tip on the marker.
What happened instead? The pin basically covers the marker.
Attach a screenshot

tallytalwar commented 7 years ago

This could be because of wrong anchor set in the style sheet or anchoring is broken on current master of tangram-es. @blair1618 I think we saw something similar on tizen (when we were testing sticker vs maker work).

karimnaaji commented 7 years ago

It's none of that, the marker in that case does not know to which other label it is linked to, parenting is broken because the parenting only exists at stylesheet creation. It seems to be more a problem of how our markers system would let markers link to already existing label features.

tallytalwar commented 7 years ago

Interesting this used to work before though. Some logic did change on core label code which is causing this to happen now.

karimnaaji commented 7 years ago

Ok so there is a regression on that side, I thought this was coming from a misusage of unified point/text style. https://github.com/tangrams/tangram-es/pull/1046

msmollin commented 7 years ago

Fixed in master-1811