Improve test coverage in MainPresenter

mapzen / eraser-map

Privacy-focused mapping application for Android

GNU General Public License v3.0

74 stars 24 forks source link

Improve test coverage in MainPresenter #777

Closed sarahsnow1 closed 7 years ago

sarahsnow1 commented 7 years ago

This PR moves logic for exiting navigation, hiding route preview, and centering on features out of the MainActivity and into the MainPresenter as well as increases test coverage. It replaces large methods with simple calls to UI elements in MainActivity. It also adds a fix to reset the tilt when navigation mode is exited. There is a lot more work to do here, this is just a start...

ecgreb commented 7 years ago

Enabling the debug menu by searching for "!!!!!!!!" while testing this branch led to a crash documented here https://github.com/mapzen/eraser-map/issues/780.

sarahsnow1 commented 7 years ago

Pushed a fix for this crash